Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid --find-links. #1583

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Avoid --find-links. #1583

merged 2 commits into from
Jun 12, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jun 12, 2024

Avoid pip --find-links which can fail to install and fall back to older wheels. See rapidsai/build-planning#69 for more information.

@bdice bdice requested a review from a team as a code owner June 12, 2024 12:28
@bdice bdice requested a review from jameslamb June 12, 2024 12:28
@bdice bdice added non-breaking Non-breaking change bug Something isn't working labels Jun 12, 2024
@github-actions github-actions bot added the ci label Jun 12, 2024
bdice
bdice commented Jun 12, 2024
View reviewed changes
ci/test_wheel.sh Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Jun 12, 2024

This problem was discovered in 24.06 nightly tests where 24.08 nightlies were fetched instead. Due to an API break in 24.08, the tests no longer pass. https://github.com/rapidsai/rmm/actions/runs/9442913121/job/26005813021#step:8:103

[rapids-download-from-s3] Downloading and decompressing s3://rapids-downloads/nightly/rmm/2024-06-10/f47ce3f/rmm_wheel_python_rmm_cu11_py310_x86_64.tar.gz into /__w/rmm/rmm/dist/
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
/__w/rmm/rmm/dist/Looking in indexes: https://pypi.org/simple, https://pypi.anaconda.org/rapidsai-wheels-nightly/simple
Looking in links: /__w/rmm/rmm/dist/
Collecting rmm-cu11[test]>=0.0.0a0
  Downloading https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/rmm-cu11/24.8.0a11/rmm_cu11-24.8.0a11-cp310-cp310-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl (1.7 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 4.0 MB/s eta 0:00:00

jameslamb
jameslamb approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks!

@jameslamb jameslamb mentioned this pull request Jun 12, 2024
Closed
@bdice
Copy link
Contributor Author

bdice commented Jun 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9c5b1ed into rapidsai:branch-24.08 Jun 12, 2024
57 checks passed
copy-pr-bot bot pushed a commit that referenced this pull request Jun 17, 2024
@bdice @rongou
Avoid --find-links. (#1583)
77b434e 
Avoid `pip --find-links` which can fail to install and fall back to older wheels. See rapidsai/build-planning#69 for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @jameslamb